[#349] Replace hardcoded $PLOT with RESERVE_LABEL constant#359
Merged
realproject7 merged 1 commit intomainfrom Mar 19, 2026
Merged
[#349] Replace hardcoded $PLOT with RESERVE_LABEL constant#359realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #349 and replaces the hardcoded reserve label with the shared RESERVE_LABEL constant in all seven affected components. The change is minimal and follows the existing constants pattern without introducing logic changes.
Findings
- No correctness or design issues found in the submitted diff.
Decision
Approved on code review. lint-and-typecheck was still pending at the time of review, so merge should still respect the required GitHub checks.
project7-interns
approved these changes
Mar 19, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
LGTM. Clean mechanical replacement across all 7 components — consistent, no logic changes, unused IS_TESTNET imports removed. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
const reserveLabel = IS_TESTNET ? "WETH" : "$PLOT"with importedRESERVE_LABELfromlib/contracts/constants.tsin all 7 affected componentsIS_TESTNETimports where no longer needed"PL_TEST"on mainnet (matching the constant updated in PR [#339] Update frontend + SDK constants for Base mainnet #342)Fixes #349
Files changed
WriterTradingStats.tsxDonateWidget.tsxClaimRoyalties.tsxReaderPortfolio.tsxPriceChart.tsxTradingWidget.tsxStoryCardStats.tsxTest plan
next buildpasses cleanly🤖 Generated with Claude Code